Skip to content

Table::getDisplayLines() should not output excessive lines when no rows #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slaFFik wants to merge 6 commits into from
Closed

Table::getDisplayLines() should not output excessive lines when no rows #165

slaFFik wants to merge 6 commits into from
+9 −7

Conversation

@slaFFik
Copy link
Contributor

@slaFFik slaFFik commented Sep 28, 2023

Fix #164.

@slaFFik slaFFik requested a review from a team as a code owner September 28, 2023 21:10
@slaFFik slaFFik changed the title Table::getDisplayLines() should not output excessive lines Table::getDisplayLines() should not output excessive lines when no rows Sep 28, 2023
danielbachhuber
danielbachhuber reviewed Sep 29, 2023
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure the tests are addressed accordingly?

@slaFFik
Copy link
Contributor Author

slaFFik commented Sep 29, 2023

Yes, sure, I will try to do that today/tomorrow.
Sorry for missing them (was in jeopardy when creating this PR and forgot to check the checks' status, my bad).

@slaFFik
Copy link
Contributor Author

slaFFik commented Sep 29, 2023

@danielbachhuber, test Test_Table_Ascii::testDrawWithHeadersNoData() fixed, all checks are 🍏.

@danielbachhuber
Copy link
Member

danielbachhuber commented Sep 29, 2023

@slaFFik What do you think about avoiding the back compat break? #164 (comment)

@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot AI review requested due to automatic review settings January 20, 2026 21:04

This comment was marked as resolved.

Sign in to view

@swissspidy
Copy link
Member

swissspidy commented Jan 20, 2026 •
edited
Loading

I think #190 fixed this as a side effect, so we can close this

@swissspidy swissspidy closed this Jan 20, 2026
@slaFFik slaFFik deleted the patch-2 branch January 21, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielbachhuber danielbachhuber danielbachhuber left review comments

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

bug scope:table

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Table::getDisplayLines() can output excessive lines

3 participants

@slaFFik @danielbachhuber @swissspidy